Re: [Qemu-devel] [PATCH 0/4] tests: enable ohci/uhci/xhci tests on PPC64

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1474899049-12506-1-git-send-email-lvivier@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] tests: enable ohci/uhci/xhci tests on PPC64

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c87b1c7 tests: enable ohci/uhci/xhci tests on PPC64
6426282 libqos: use generic qtest_shutdown()
c8ef4b1 libqos: add PCI management in qtest_vboot()/qtest_shutdown()
781f32e libqos: add PPC64 PCI support

=== OUTPUT BEGIN ===
Checking PATCH 1/4: libqos: add PPC64 PCI support...
Checking PATCH 2/4: libqos: add PCI management in qtest_vboot()/qtest_shutdown()...
Checking PATCH 3/4: libqos: use generic qtest_shutdown()...
Checking PATCH 4/4: tests: enable ohci/uhci/xhci tests on PPC64...
ERROR: do not initialise statics to 0 or NULL
#51: FILE: tests/libqos/usb.c:23:
+static const bool host_big_endian = false;

total: 1 errors, 0 warnings, 105 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org