From: Ralf Baechle <ralf@linux-mips.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [mips-sjhill:mips-for-linux-next 58/62] arch/mips/kernel/uprobes.c:304:15: error: variable or field 'kstart' declared void
Date: Mon, 26 Sep 2016 17:29:30 +0200 [thread overview]
Message-ID: <20160926152930.GE12981@linux-mips.org> (raw)
In-Reply-To: <5302CFBF-1016-4704-B3AE-3BD986E5DD3B@imgtec.com>
On Mon, Sep 26, 2016 at 02:07:03PM +0100, James Hogan wrote:
> My intention was I think for kstart to be void * (and to use void * arithmetic), but i'm indifferent if you prefer unsigned long for that. Apparently my build coverage was lacking for this patch, sorry about that!
Standard C doesn't allow arithmetic on void pointers; GCC does so as
an extension over standard C - and I tend to avoid such extensions, if
possible. I also tend to prefer unsigned long at a low level for things
such as cache flush operations - but more importantly I try to keep the
number of casts down.
Ralf
prev parent reply other threads:[~2016-09-26 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 18:06 [mips-sjhill:mips-for-linux-next 58/62] arch/mips/kernel/uprobes.c:304:15: error: variable or field 'kstart' declared void kbuild test robot
2016-09-26 10:24 ` Ralf Baechle
2016-09-26 13:07 ` James Hogan
2016-09-26 15:29 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926152930.GE12981@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.