From: Oleg Nesterov <oleg@redhat.com>
To: Waiman Long <Waiman.Long@hpe.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Stas Sergeev <stsp@list.ru>,
linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>
Subject: Re: [PATCH v2] signals: Avoid unnecessary taking of sighand->siglock
Date: Mon, 26 Sep 2016 18:28:31 +0200 [thread overview]
Message-ID: <20160926162831.GB6782@redhat.com> (raw)
In-Reply-To: <1474649774-48834-1-git-send-email-Waiman.Long@hpe.com>
On 09/23, Waiman Long wrote:
>
>
> + /*
> + * In case the signal mask hasn't changed, we won't need to take
> + * the lock. The current blocked mask can be modified by other CPUs.
> + * To be safe, we need to do an atomic read without lock. As a result,
> + * this check will only be done on 64-bit architectures.
> + */
> + if ((_NSIG_WORDS == 1) &&
> + (READ_ONCE(tsk->blocked.sig[0]) == newset->sig[0]))
> + return;
so in case you missed my reply to V1, I still think that the comment is wrong
and you should drop the _NSIG_WORDS check.
Oleg.
prev parent reply other threads:[~2016-09-26 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 16:56 [PATCH v2] signals: Avoid unnecessary taking of sighand->siglock Waiman Long
2016-09-23 19:43 ` Stas Sergeev
2016-09-26 21:24 ` Waiman Long
2016-09-26 16:28 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926162831.GB6782@redhat.com \
--to=oleg@redhat.com \
--cc=Waiman.Long@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=doug.hatch@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=scott.norton@hpe.com \
--cc=stsp@list.ru \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.