From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit
Date: Tue, 27 Sep 2016 18:13:38 +0800 [thread overview]
Message-ID: <20160927101338.GB13510@lemon> (raw)
In-Reply-To: <1474968813-14181-1-git-send-email-famz@redhat.com>
On Tue, 09/27 17:33, Fam Zheng wrote:
> We already specified BDRV_O_UNMAP when opening images in 'qemu-img
> commit', but didn't turn on the "unmap" in the active commit job. This
> patch fixes that so that zeroed clusters in top image can be discarded
> which is desired in the virt-sparsify use case, where a temporary
> overlay is created and fstrim'ed before commiting back, to free space in
> the original image.
>
> This also enables it for block-commit.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Sent too soon. I see a number of iotests failures (020 040 097 129),
still investigating.
Fam
next prev parent reply other threads:[~2016-09-27 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:33 [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit Fam Zheng
2016-09-27 10:13 ` Fam Zheng [this message]
2016-09-27 11:04 ` Fam Zheng
2016-09-27 11:15 ` Kevin Wolf
2016-09-27 11:29 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927101338.GB13510@lemon \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.