Re: [PATCH 2/2] staging: vt6656: Make return type changes of functions

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Sep 26, 2016 at 11:56:10PM +0530, Namrata A Shettar wrote:
> Change return type of functions to reflect changes in code.
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  drivers/staging/vt6656/card.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/card.h b/drivers/staging/vt6656/card.h
> index c2cde7e..84270c1 100644
> --- a/drivers/staging/vt6656/card.h
> +++ b/drivers/staging/vt6656/card.h
> @@ -41,14 +41,14 @@ void vnt_update_ifs(struct vnt_private *);
>  void vnt_update_top_rates(struct vnt_private *);
>  int vnt_ofdm_min_rate(struct vnt_private *);
>  void vnt_adjust_tsf(struct vnt_private *, u8, u64, u64);
> -bool vnt_get_current_tsf(struct vnt_private *, u64 *);
> +void vnt_get_current_tsf(struct vnt_private *, u64 *);
>  bool vnt_clear_current_tsf(struct vnt_private *);
>  void vnt_reset_next_tbtt(struct vnt_private *, u16);
>  void vnt_update_next_tbtt(struct vnt_private *, u64, u16);
>  u64 vnt_get_next_tbtt(u64, u16);
>  u64 vnt_get_tsf_offset(u8 byRxRate, u64 qwTSF1, u64 qwTSF2);
> -int vnt_radio_power_off(struct vnt_private *);
> -int vnt_radio_power_on(struct vnt_private *);
> +void vnt_radio_power_off(struct vnt_private *);
> +void vnt_radio_power_on(struct vnt_private *);
>  u8 vnt_get_pkt_type(struct vnt_private *);
>  void vnt_set_bss_mode(struct vnt_private *);

You have to do this in your first patch, as the build broke without
these changes, right?

You can never break the build with any single patch.

Please fix up and resend.

thanks,

greg k-h