From: Greg KH <gregkh@linuxfoundation.org>
To: Anchal Jain <anchalj109@gmail.com>
Cc: Michael.Hennerich@analog.com, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: iio: cdc: add comment to mutex
Date: Tue, 27 Sep 2016 13:16:08 +0200 [thread overview]
Message-ID: <20160927111608.GA18326@kroah.com> (raw)
In-Reply-To: <20160927104504.GA13155@life-desktop>
On Tue, Sep 27, 2016 at 04:15:12PM +0530, Anchal Jain wrote:
> Fix the checkpatch.pl issues:
> CHECK: struct mutes definition without comment
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> drivers/staging/iio/cdc/ad7150.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index f6b9a10..88c6ebe 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -78,7 +78,7 @@ struct ad7150_chip_info {
> u8 mag_timeout[2][2];
> int old_state;
> char *conversion_mode;
> - struct mutex state_lock;
> + struct mutex state_lock; /*generic mutex for cdc and drivers*/
That's the best description for this? I don't understand this, do you?
Why no ' ' after and before '*'?
thnks,
greg k-h
next prev parent reply other threads:[~2016-09-27 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 10:45 [PATCH] staging: iio: cdc: add comment to mutex Anchal Jain
2016-09-27 11:16 ` Greg KH [this message]
2016-09-27 12:16 ` Anchal Jain
2016-09-27 12:53 ` [Outreachy kernel] " Julia Lawall
2016-09-27 17:07 ` [Outreachy kernel] " Alison Schofield
2016-09-27 19:46 ` Alison Schofield
2016-09-28 17:00 ` Anchal Jain
2016-09-28 17:34 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927111608.GA18326@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=anchalj109@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.