Re: [PATCH v2] staging: sm750fb: rename camelCase macro

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Sep 27, 2016 at 11:46:34AM -0700, Elizabeth Ferdman wrote:
> This patch renames a camelcase macro roundedDiv to rounded_div. Error found by checkpatch.

please wrap your changelog comments at 72 columns.

> 
> Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
> ---
> Changes in v2:
> 	- Revise commit message and description
> 
>  drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index f557b6d..81df4c4 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -7,7 +7,7 @@
>  #include "ddk750_power.h"
>  
>  /* n / d + 1 / 2 = (2n + d) / 2d */
> -#define roundedDiv(num, denom)	((2 * (num) + (denom)) / (2 * (denom)))
> +#define rounded_div(num, denom)	((2 * (num) + (denom)) / (2 * (denom)))

Ick, now it looks like a function, which it isn't :(

I think the kernel already has this function somewhere, can you just use
a built-in one instead?  Dig around in the include/linux/ directory.

And if not, can you change this to an inline function, that way you
don't accidentally evaluate denom twice, potentially causing bad problems.

thanks,

greg k-h