From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [kvm-unit-tests PATCH v7 00/13] PCI bus support Date: Wed, 28 Sep 2016 14:33:09 +0800 Message-ID: <20160928063309.GC11134@pxdev.xzpeter.org> References: <20160817142654.y22h5fch4gdk7qq6@kamzik.localdomain> <20160823182805.GB3478@agordeev.lab.eng.brq.redhat.com> <20160922111004.45znovqflj6fgrnr@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Alexander Gordeev , kvm@vger.kernel.org, Thomas Huth , Paolo Bonzini To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44976 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750700AbcI1GdO (ORCPT ); Wed, 28 Sep 2016 02:33:14 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DF9EC04B30F for ; Wed, 28 Sep 2016 06:33:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160922111004.45znovqflj6fgrnr@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 22, 2016 at 01:10:04PM +0200, Andrew Jones wrote: [...] > I finally had a chance to take a look at this. There's no BAR#4 being > exposed from pci-testdev. QEMU is adding a default virtio-net-pci device, > which does have a BAR#4. Adjusting the QEMU env like this > > export QEMU="$QEMU -nodefaults" > > which removes default devices, allows the new unit test to run and pass. > > kvm-unit-tests shouldn't be asserting and dying when it's presented a > valid virtio-net-pci device though. It should handle the probing > correctly, or at least just warn that it doesn't know how to, and then > ignore it. Alex, can you consider what might need to be tweaked in this > series to do that? > > That said, as kvm-unit-tests isn't going to drive non-testdev devices > anyway, then just removing default devices is a reasonable thing to do > too. I'll submit a patch adding '-nodefaults -nodefconfig' to the arm > QEMU command line. Could I ask what's the status of this series? I see that this is still not in master (nor did I saw any further works from Alex). Thanks, -- peterx