All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: schwab@suse.de
Cc: famz@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] linux-user: remove all traces of qemu from /proc/self/cmdline
Date: Wed, 28 Sep 2016 07:43:13 -0700 (PDT)	[thread overview]
Message-ID: <20160928144310.227108.53318@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <mvma8es147b.fsf@hawking.suse.de>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: mvma8es147b.fsf@hawking.suse.de
Subject: [Qemu-devel] [PATCH] linux-user: remove all traces of qemu from /proc/self/cmdline

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20160928143810.25558-1-marcandre.lureau@redhat.com -> patchew/20160928143810.25558-1-marcandre.lureau@redhat.com
 * [new tag]         patchew/mvma8es147b.fsf@hawking.suse.de -> patchew/mvma8es147b.fsf@hawking.suse.de
Switched to a new branch 'test'
7506c8f linux-user: remove all traces of qemu from /proc/self/cmdline

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: remove all traces of qemu from /proc/self/cmdline...
ERROR: space prohibited between function name and open parenthesis '('
#37: FILE: linux-user/syscall.c:7123:
+        size_t len = strlen (bprm->argv[i]) + 1;

total: 1 errors, 0 warnings, 59 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  reply	other threads:[~2016-09-28 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 14:36 [Qemu-devel] [PATCH] linux-user: remove all traces of qemu from /proc/self/cmdline Andreas Schwab
2016-09-28 14:43 ` no-reply [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-31 10:43 Andreas Schwab
2017-03-20 11:31 Andreas Schwab
2017-05-19 13:59 ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928144310.227108.53318@ex-std-node742.prod.rhcloud.com \
    --to=no-reply@patchew.org \
    --cc=afaerber@suse.de \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.