From: Elizabeth Ferdman <gnudevliz@gmail.com>
To: Alison Schofield <amsfield22@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: line wrap and rebase question
Date: Wed, 28 Sep 2016 11:19:56 -0700 [thread overview]
Message-ID: <20160928181956.GA2193@localhost> (raw)
In-Reply-To: <20160927222001.GA21768@d830.WORKGROUP>
Hey Alison,
Good morning! I received some not so good feedback from Greg that I want
to fix and I have a bunch of questions. The plus side is that maybe
some of the answers could go into the tutorial.
First he said "please wrap your changelog comments at 72 columns."
Is this something I add to my .vimrc? I've been using "git commit -m".
is that causing the issue? I thought git commit messages were supposed
to be less than 50 chars anyway. I'm confused.
The other issue was that my commit didn't apply to his tree. He says
please rebase and resend. I think I need to do:
$ git fetch origin
$ git rebase origin/staging-testing
Then reformat the patch?
$ git format-patch -o ~/mypatches/ HEAD^
$ mutt -H <file>
So I don't need to uncommit/recommit?
Thanks,
Liz
next prev parent reply other threads:[~2016-09-28 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 19:49 TODO/comment questions gnudevliz
2016-09-27 20:04 ` [Outreachy kernel] " Alison Schofield
2016-09-27 20:16 ` Julia Lawall
[not found] ` <20160927203553.GA20780@d830.WORKGROUP>
[not found] ` <20160927220413.GA23877@localhost>
[not found] ` <20160927222001.GA21768@d830.WORKGROUP>
2016-09-28 18:19 ` Elizabeth Ferdman [this message]
2016-09-28 20:32 ` line wrap and rebase question Alison Schofield
2016-09-28 20:43 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928181956.GA2193@localhost \
--to=gnudevliz@gmail.com \
--cc=amsfield22@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.