From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Pravin Shelar <pshelar@ovn.org>,
netdev@vger.kernel.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call
Date: Wed, 28 Sep 2016 20:11:36 +0300 [thread overview]
Message-ID: <20160928201136.1600ac65@halley> (raw)
In-Reply-To: <57EBD71A.90104@iogearbox.net>
On Wed, 28 Sep 2016 16:43:38 +0200 Daniel Borkmann <daniel@iogearbox.net> wrote:
> > (1) suppose upon entry we have
> >
> > DA,SA,0x8100,TCI,0x0800,
> > ^ ^
> > mac_hdr data
> >
> > initial offset is 18, and after current unwinding code we'll get
>
> You mean data points after the 0x0800, right?
Sorry. Yes, exactly as you say. Initially 18 bytes ahead:
DA,SA,0x8100,TCI,0x0800,
^ ^
mac_hdr data
next prev parent reply other threads:[~2016-09-28 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:08 [PATCH v2 net] net: skbuff: skb_vlan_push: Fix wrong unwinding of skb->data after __vlan_insert_tag call Shmulik Ladkani
2016-09-28 10:30 ` Daniel Borkmann
2016-09-28 11:56 ` Shmulik Ladkani
2016-09-28 14:43 ` Daniel Borkmann
2016-09-28 17:11 ` Shmulik Ladkani [this message]
2016-09-28 17:42 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928201136.1600ac65@halley \
--to=shmulik.ladkani@ravellosystems.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.