From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpR37-0000oE-NV for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpR34-0002BO-BJ for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:13 -0400 Date: Thu, 29 Sep 2016 12:22:51 +1000 From: David Gibson Message-ID: <20160929022251.GG8390@umbus.fritz.box> References: <1475041518-9757-1-git-send-email-raji@linux.vnet.ibm.com> <1475041518-9757-6-git-send-email-raji@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="64j1qyTOoGvYcHb1" Content-Disposition: inline In-Reply-To: <1475041518-9757-6-git-send-email-raji@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 5/6] target-ppc: add vector compare not equal instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rajalakshmi Srinivasaraghavan Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org --64j1qyTOoGvYcHb1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2016 at 11:15:17AM +0530, Rajalakshmi Srinivasaraghavan wro= te: > The following vector compare not equal instructions are added from ISA 3.= 0. >=20 > vcmpneb - Vector Compare Not Equal Byte > vcmpneh - Vector Compare Not Equal Halfword > vcmpnew - Vector Compare Not Equal Word >=20 > Signed-off-by: Rajalakshmi Srinivasaraghavan > Applied to ppc-for-2.8. > --- > target-ppc/helper.h | 6 ++++++ > target-ppc/int_helper.c | 31 +++++++++++++++++++----------= -- > target-ppc/translate/vmx-impl.inc.c | 11 ++++++++++- > target-ppc/translate/vmx-ops.inc.c | 6 +++--- > 4 files changed, 38 insertions(+), 16 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index aef2f30..9c3095f 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -147,6 +147,9 @@ DEF_HELPER_4(vcmpequb, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequh, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequw, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequd, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpneb, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpneh, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnew, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezb, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezh, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezw, void, env, avr, avr, avr) > @@ -166,6 +169,9 @@ DEF_HELPER_4(vcmpequb_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequh_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequw_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequd_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpneb_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpneh_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnew_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezb_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezh_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpnezw_dot, void, env, avr, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 09a1799..f132f7b 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -735,20 +735,24 @@ VCMP(gtsd, >, s64) > #undef VCMP_DO > #undef VCMP > =20 > -#define VCMPNEZ_DO(suffix, element, etype, record) \ > -void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r, \ > +#define VCMPNE_DO(suffix, element, etype, cmpzero, record) \ > +void helper_vcmpne##suffix(CPUPPCState *env, ppc_avr_t *r, \ > ppc_avr_t *a, ppc_avr_t *b) \ > { \ > etype ones =3D (etype)-1; = \ > etype all =3D ones; = \ > - etype none =3D 0; = \ > + etype result, none =3D 0; = \ > int i; \ > \ > for (i =3D 0; i < ARRAY_SIZE(r->element); i++) { = \ > - etype result =3D ((a->element[i] =3D=3D 0) = \ > + if (cmpzero) { \ > + result =3D ((a->element[i] =3D=3D 0) = \ > || (b->element[i] =3D=3D 0) = \ > || (a->element[i] !=3D b->element[i]) ? = \ > ones : 0x0); \ > + } else { \ > + result =3D (a->element[i] !=3D b->element[i]) ? ones : 0x0; = \ > + } \ > r->element[i] =3D result; = \ > all &=3D result; = \ > none |=3D result; = \ > @@ -762,14 +766,17 @@ void helper_vcmpnez##suffix(CPUPPCState *env, ppc_a= vr_t *r, \ > * suffix - instruction mnemonic suffix (b: byte, h: halfword, w: wor= d) > * element - element type to access from vector > */ > -#define VCMPNEZ(suffix, element, etype) \ > - VCMPNEZ_DO(suffix, element, etype, 0) \ > - VCMPNEZ_DO(suffix##_dot, element, etype, 1) > -VCMPNEZ(b, u8, uint8_t) > -VCMPNEZ(h, u16, uint16_t) > -VCMPNEZ(w, u32, uint32_t) > -#undef VCMPNEZ_DO > -#undef VCMPNEZ > +#define VCMPNE(suffix, element, etype, cmpzero) \ > + VCMPNE_DO(suffix, element, etype, cmpzero, 0) \ > + VCMPNE_DO(suffix##_dot, element, etype, cmpzero, 1) > +VCMPNE(zb, u8, uint8_t, 1) > +VCMPNE(zh, u16, uint16_t, 1) > +VCMPNE(zw, u32, uint32_t, 1) > +VCMPNE(b, u8, uint8_t, 0) > +VCMPNE(h, u16, uint16_t, 0) > +VCMPNE(w, u32, uint32_t, 0) > +#undef VCMPNE_DO > +#undef VCMPNE > =20 > #define VCMPFP_DO(suffix, compare, order, record) \ > void helper_vcmp##suffix(CPUPPCState *env, ppc_avr_t *r, \ > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 10641dc..0bc7188 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -608,7 +608,16 @@ GEN_VXRFORM(vcmpeqfp, 3, 3) > GEN_VXRFORM(vcmpgefp, 3, 7) > GEN_VXRFORM(vcmpgtfp, 3, 11) > GEN_VXRFORM(vcmpbfp, 3, 15) > - > +GEN_VXRFORM(vcmpneb, 3, 0) > +GEN_VXRFORM(vcmpneh, 3, 1) > +GEN_VXRFORM(vcmpnew, 3, 2) > + > +GEN_VXRFORM_DUAL(vcmpequb, PPC_NONE, PPC2_ALTIVEC_207, \ > + vcmpneb, PPC_NONE, PPC2_ISA300) > +GEN_VXRFORM_DUAL(vcmpequh, PPC_NONE, PPC2_ALTIVEC_207, \ > + vcmpneh, PPC_NONE, PPC2_ISA300) > +GEN_VXRFORM_DUAL(vcmpequw, PPC_NONE, PPC2_ALTIVEC_207, \ > + vcmpnew, PPC_NONE, PPC2_ISA300) > GEN_VXRFORM_DUAL(vcmpeqfp, PPC_ALTIVEC, PPC_NONE, \ > vcmpequd, PPC_NONE, PPC2_ALTIVEC_207) > GEN_VXRFORM_DUAL(vcmpbfp, PPC_ALTIVEC, PPC_NONE, \ > diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vm= x-ops.inc.c > index 87be6c6..009e9b1 100644 > --- a/target-ppc/translate/vmx-ops.inc.c > +++ b/target-ppc/translate/vmx-ops.inc.c > @@ -185,9 +185,6 @@ GEN_HANDLER2_E(name, str, 0x4, opc2, opc3, 0x00000000= , PPC_NONE, PPC2_ISA300), > GEN_VXRFORM1_300(name, name, #name, opc2, opc3) = \ > GEN_VXRFORM1_300(name##_dot, name##_, #name ".", opc2, (opc3 | (0x1 = << 4))) > =20 > -GEN_VXRFORM(vcmpequb, 3, 0) > -GEN_VXRFORM(vcmpequh, 3, 1) > -GEN_VXRFORM(vcmpequw, 3, 2) > GEN_VXRFORM_300(vcmpnezb, 3, 4) > GEN_VXRFORM_300(vcmpnezh, 3, 5) > GEN_VXRFORM_300(vcmpnezw, 3, 6) > @@ -201,6 +198,9 @@ GEN_VXRFORM_DUAL(vcmpeqfp, vcmpequd, 3, 3, PPC_ALTIVE= C, PPC_NONE) > GEN_VXRFORM(vcmpgefp, 3, 7) > GEN_VXRFORM_DUAL(vcmpgtfp, vcmpgtud, 3, 11, PPC_ALTIVEC, PPC_NONE) > GEN_VXRFORM_DUAL(vcmpbfp, vcmpgtsd, 3, 15, PPC_ALTIVEC, PPC_NONE) > +GEN_VXRFORM_DUAL(vcmpequb, vcmpneb, 3, 0, PPC_NONE, PPC2_ALTIVEC_207) > +GEN_VXRFORM_DUAL(vcmpequh, vcmpneh, 3, 1, PPC_NONE, PPC2_ALTIVEC_207) > +GEN_VXRFORM_DUAL(vcmpequw, vcmpnew, 3, 2, PPC_NONE, PPC2_ALTIVEC_207) > =20 > #define GEN_VXFORM_DUAL_INV(name0, name1, opc2, opc3, inval0, inval1, ty= pe) \ > GEN_OPCODE_DUAL(name0##_##name1, 0x04, opc2, opc3, inval0, inval1, type,= \ --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --64j1qyTOoGvYcHb1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX7Hr7AAoJEGw4ysog2bOSIrQQAImNfmzSSalif+iKLXqeOLlW a8sY1JGL9BimMre1enJXOunvpS/+2mwLXcwqd3AqT4tDXbAv5BjE+VzMqIRKfCZV LymfT5kfr+l7nvw7LmJRhM3jhjg2ndTR4DOyIOVoW9Bl0HzxzV/xI9aJFdXGR7MB RFjZt3lSfWszldDy3BD+KvP6N+PhcU5OJch7hPp+F8dAksluSWEG+t1neJ4SMkvt DHnSvg9F/fiS3cEroEztkWAEeXkn9Slp80mr3g6SY9YpyTBkyKpzzWuBMQ/ufveu JuVON1DhC2ckOm/aWqG6P21szYOY6MZMee7o8pktzseFO4TSACNHQc6559Q4QB2y Eoxt46CUR+g2w8lf+r89UZHRaUx2uInJ36jY4F4uS7dLpJhDDikADFUE30Vj+9hF AndzEBTk0Q/tldCGALxLKj+usHTZ0vPzRZdvIlMvW/mzGEYdvXWUWTxk9bis3p7A QbA1Tkrw1ttwX/SYQiaiHrIKu9SpY73hfeq9e7xigGaZjXmiWviiCxFCFKfFaphB l7/MxNqTYOXj+yM1IzLkJZCu4dp2Q926j/PwOaM6rTuYTbav36JUdwdoFVxpbyCM 9gpMEDg4iyDx4f2XS9z4HMDk1BJh55OZvQb03Nhf2A5pxgt+We2gFvlX8T7M9uWV 5IHuencoc+mKLGTqwmN9 =36YC -----END PGP SIGNATURE----- --64j1qyTOoGvYcHb1--