From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpRoF-0005Um-Bg for qemu-devel@nongnu.org; Wed, 28 Sep 2016 23:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpRoD-00050M-IS for qemu-devel@nongnu.org; Wed, 28 Sep 2016 23:14:54 -0400 Date: Thu, 29 Sep 2016 11:14:44 +0800 From: Fam Zheng Message-ID: <20160929031444.GE6412@lemon> References: <1474958276-7715-1-git-send-email-famz@redhat.com> <1474958276-7715-2-git-send-email-famz@redhat.com> <6d56ac2d-aa76-f323-085b-54f0dd4e519c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d56ac2d-aa76-f323-085b-54f0dd4e519c@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/5] blockdev-mirror: Sanity check before moving target_bs AioContext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf , qemu-stable@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com On Wed, 09/28 18:37, Max Reitz wrote: > On 27.09.2016 08:37, Fam Zheng wrote: > > Similar to blockdev-backup, if the target was already moved to a > > different AioContext, bad things can happen. This happens when the > > target belongs to a data plane device. It's a very unlikely case, but > > let's check it anyway. > > You didn't implement it for blockdev-mirror, though, but for > drive-mirror (which I don't think needs this check). Ugh, will fix.