From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] Sparc/prom/ranges.c cosmetic improvement
Date: Thu, 29 Sep 2016 04:50:13 +0000 [thread overview]
Message-ID: <20160929045013.GA30814@ravnborg.org> (raw)
In-Reply-To: <20160928214625.GA24725@netmonk.localdomain>
On Wed, Sep 28, 2016 at 11:46:25PM +0200, netmonk@netmonk.org wrote:
> Following Linux Coding Style documentation, removed, added some spaces
> to improve compliance to the formating standard.
>
> Signed-of-by: Netmonk <netmonk@netmonk.org>
>
>
> >From 276b83b74716cbd39c6c72428c6e385881b089e7 Mon Sep 17 00:00:00 2001
> From: netmonk <netmonk@netmonk.org>
> Date: Wed, 28 Sep 2016 23:26:33 +0200
> Subject: [PATCH] Cosmetic improvement in arch/sparc/prom/ranges.c
>
> ---
> arch/sparc/prom/ranges.c | 31 +++++++++++++------------------
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/arch/sparc/prom/ranges.c b/arch/sparc/prom/ranges.c
> index ad143c1..a493de3 100644
> --- a/arch/sparc/prom/ranges.c
> +++ b/arch/sparc/prom/ranges.c
> @@ -16,8 +16,7 @@ static struct linux_prom_ranges promlib_obio_ranges[PROMREG_MAX];
> static int num_obio_ranges;
>
> /* Adjust register values based upon the ranges parameters. */
> -static void
> -prom_adjust_regs(struct linux_prom_registers *regp, int nregs,
> +static void prom_adjust_regs(struct linux_prom_registers *regp, int nregs,
> struct linux_prom_ranges *rangep, int nranges)
The arguments on the second line shall be aligned with the first line.
Use tabs and then the number of spaces required.
In this case "struct linux_*" and "struct linux_*" shall be just below each other.
Fix up similar bug in rest of the patch.
Sam
next prev parent reply other threads:[~2016-09-29 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 21:46 [PATCH] Sparc/prom/ranges.c cosmetic improvement netmonk
2016-09-29 4:50 ` Sam Ravnborg [this message]
2016-09-29 4:51 ` Sam Ravnborg
2016-09-29 19:52 ` netmonk
2016-09-30 4:29 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929045013.GA30814@ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.