From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpWNt-0001lE-2K for qemu-devel@nongnu.org; Thu, 29 Sep 2016 04:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpWNr-0007q7-22 for qemu-devel@nongnu.org; Thu, 29 Sep 2016 04:07:59 -0400 Date: Thu, 29 Sep 2016 09:07:47 +0100 From: "Richard W.M. Jones" Message-ID: <20160929080747.GR26315@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] block/ssh:Allow blockdev-add for ssh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: jcody@redhat.com, QEMU Developers , qemu-block@nongnu.org On Thu, Sep 29, 2016 at 01:05:48PM +0530, Ashijeet Acharya wrote: > Hi all, > > I was trying to convert SSH driver to support 'blockdev-add' and so > far I have tried to figure out what the struct 'BlockdevOptionsSsh' in > block-core.json should look like, > > { 'struct': 'BlockdevOptionsSsh', > 'data': { 'tcp': 'InetSocketAddress', > 'path': 'str' } } > > Naive question but I have to ask, Am I missing something? > > As far as I know, ssh only supports 'tcp' right? So using > 'InetSocketAddress' should be good enough. (like the TODO says) > > I had a discussion with Kevin about this and he thinks, maybe > 'SocketAddress' can be used too because the restriction comes from the > qemu block driver rather than the backend. He advised me to get an > opinion on this one from the maintainers of SSH. I have no idea. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW