From: "tj@kernel.org" <tj@kernel.org>
To: Adam Manzanares <Adam.Manzanares@hgst.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 0/3] Enabling ATA Command Priorities
Date: Thu, 29 Sep 2016 10:48:34 +0200 [thread overview]
Message-ID: <20160929084834.GD11087@mtj.duckdns.org> (raw)
In-Reply-To: <5C8FF242-7C7B-442E-A6FF-89878366F154@hgst.com>
Hello,
On Wed, Sep 28, 2016 at 03:43:32AM +0000, Adam Manzanares wrote:
> I prefer having the feature conditional so you can use the CFQ
> scheduler with I/O priorities as is. If you decide to enable the
> feature then the priorities will be passed down to the drive in
> addition to the work that the CFQ scheduler does. Since this feature
> may change the user perceived performance of the device I want to
> make sure they know what they are getting into.
Yeah, I prefer to have it behind an explicit flag given the history of
optional ATA features. The feature is unlikely to matter to a lot of
people and is almost bound to break existing RT prio usages.
Thanks.
--
tejun
prev parent reply other threads:[~2016-09-29 8:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:14 [PATCH 0/3] Enabling ATA Command Priorities Adam Manzanares
2016-09-27 18:14 ` Adam Manzanares
2016-09-27 18:14 ` [PATCH 1/3] block: Add iocontext priority to request Adam Manzanares
2016-09-27 18:14 ` Adam Manzanares
2016-09-29 8:40 ` Tejun Heo
2016-09-30 16:02 ` Adam Manzanares
2016-09-30 16:02 ` Adam Manzanares
2016-10-02 8:53 ` Tejun Heo
2016-10-04 15:49 ` Adam Manzanares
2016-10-04 15:49 ` Adam Manzanares
2016-10-04 20:52 ` Tejun Heo
2016-09-27 18:14 ` [PATCH 2/3] ata: Enabling ATA Command Priorities Adam Manzanares
2016-09-27 18:14 ` Adam Manzanares
2016-09-29 8:45 ` Tejun Heo
2016-09-30 16:04 ` Adam Manzanares
2016-09-30 16:04 ` Adam Manzanares
2016-09-27 18:14 ` [PATCH 3/3] ata: ATA Command Priority Disabled By Default Adam Manzanares
2016-09-27 18:14 ` Adam Manzanares
2016-09-28 2:06 ` [PATCH 0/3] Enabling ATA Command Priorities Christoph Hellwig
2016-09-28 3:43 ` Adam Manzanares
2016-09-28 3:43 ` Adam Manzanares
2016-09-29 8:48 ` tj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929084834.GD11087@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Adam.Manzanares@hgst.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.