From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1bpZzh-0001fp-87
	for qemu-devel@nongnu.org; Thu, 29 Sep 2016 07:59:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1bpZzg-0003PV-9F
	for qemu-devel@nongnu.org; Thu, 29 Sep 2016 07:59:17 -0400
Date: Thu, 29 Sep 2016 12:59:05 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20160929115905.GS26315@redhat.com>
References: <CAC2QTZbtfrJ-pgs2L1+_8NvVREap+aJDztTvVn+hBjAe0a2iLg@mail.gmail.com>
	<20160929080747.GR26315@redhat.com>
	<20160929104234.GH5742@noname.redhat.com>
	<20160929112238.GP5312@redhat.com>
	<20160929113635.GK5742@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160929113635.GK5742@noname.redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] block/ssh:Allow blockdev-add for ssh
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, qemu-block@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>, Ashijeet Acharya <ashijeetacharya@gmail.com>

On Thu, Sep 29, 2016 at 01:36:35PM +0200, Kevin Wolf wrote:
> But the ssh client doesn't seem to support connection to that Unix domain
> socket, even if it would be possible to support in theory. And probably
> none of the SSH libraries that we consider to use support it either (but
> I haven't checked that).

So I checked this.  libssh2 (which is the one we're using) does
not appear to support AF_UNIX for the ssh connection.

We should most likely change over the libssh which is a better
library.  That library does in fact support AF_UNIX connections
through the ssh_socket_unix API, although that's of dubious utility
considering that almost no one runs an sshd listening on a Unix domain
socket.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v