All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sandhya Bankar <bankarsandhya512@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	knaack.h@gmx.de, pmeerw@pmeerw.net,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] drivers: iio: meter: ade7753: Replace IIO_DEV_ATTR_SAMP_FREQ attribute with IIO_CHAN_INFO_SAMP_FREQ handlers.
Date: Thu, 29 Sep 2016 17:59:40 +0200	[thread overview]
Message-ID: <20160929155940.GA30055@kroah.com> (raw)
In-Reply-To: <20160929155417.GA5224@localhost.localdomain>

On Thu, Sep 29, 2016 at 09:24:17PM +0530, Sandhya Bankar wrote:
> Moved functionality from IIO_DEV_ATTR_SAMP_FREQ attribute into 
> IIO_CHAN_INFO_SAMP_FREQ handlers. Added ade7753_read_raw() and 
> ade7753_write_raw() to allow reading/writing the element as well.

That says what you did, but why would you want to do this?

What benefit is this?  Why do this churn at all?

Changelogs should say why you do something, not just what you did.
Hopefully what you do should be obvious from the diff itself.

thanks,

greg k-h


  reply	other threads:[~2016-09-29 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 15:54 [PATCH] drivers: iio: meter: ade7753: Replace IIO_DEV_ATTR_SAMP_FREQ attribute with IIO_CHAN_INFO_SAMP_FREQ handlers Sandhya Bankar
2016-09-29 15:59 ` Greg KH [this message]
2016-09-29 16:47   ` Sandhya Bankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929155940.GA30055@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=bankarsandhya512@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.