From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4 09/12] dax: correct dax iomap code namespace Date: Fri, 30 Sep 2016 10:51:11 +0200 Message-ID: <20160930085111.GF19738@lst.de> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org To: Ross Zwisler Return-path: Content-Disposition: inline In-Reply-To: <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-ext4.vger.kernel.org On Thu, Sep 29, 2016 at 04:49:27PM -0600, Ross Zwisler wrote: > The recently added DAX functions that use the new struct iomap data > structure were named iomap_dax_rw(), iomap_dax_fault() and > iomap_dax_actor(). These are actually defined in fs/dax.c, though, so > should be part of the "dax" namespace and not the "iomap" namespace. > Rename them to dax_iomap_rw(), dax_iomap_fault() and dax_iomap_actor() > respectively. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner I don't really care either way, but this is trivial enought to not introduce a bug, so: Reviewed-by: Christoph Hellwig -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23B721A1DF7 for ; Fri, 30 Sep 2016 01:51:13 -0700 (PDT) Date: Fri, 30 Sep 2016 10:51:11 +0200 From: Christoph Hellwig Subject: Re: [PATCH v4 09/12] dax: correct dax iomap code namespace Message-ID: <20160930085111.GF19738@lst.de> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ross Zwisler Cc: Theodore Ts'o , Matthew Wilcox , Dave Chinner , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Christoph Hellwig List-ID: On Thu, Sep 29, 2016 at 04:49:27PM -0600, Ross Zwisler wrote: > The recently added DAX functions that use the new struct iomap data > structure were named iomap_dax_rw(), iomap_dax_fault() and > iomap_dax_actor(). These are actually defined in fs/dax.c, though, so > should be part of the "dax" namespace and not the "iomap" namespace. > Rename them to dax_iomap_rw(), dax_iomap_fault() and dax_iomap_actor() > respectively. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner I don't really care either way, but this is trivial enought to not introduce a bug, so: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:41770 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbcI3IvN (ORCPT ); Fri, 30 Sep 2016 04:51:13 -0400 Date: Fri, 30 Sep 2016 10:51:11 +0200 From: Christoph Hellwig Subject: Re: [PATCH v4 09/12] dax: correct dax iomap code namespace Message-ID: <20160930085111.GF19738@lst.de> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org On Thu, Sep 29, 2016 at 04:49:27PM -0600, Ross Zwisler wrote: > The recently added DAX functions that use the new struct iomap data > structure were named iomap_dax_rw(), iomap_dax_fault() and > iomap_dax_actor(). These are actually defined in fs/dax.c, though, so > should be part of the "dax" namespace and not the "iomap" namespace. > Rename them to dax_iomap_rw(), dax_iomap_fault() and dax_iomap_actor() > respectively. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner I don't really care either way, but this is trivial enought to not introduce a bug, so: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932577AbcI3IvZ (ORCPT ); Fri, 30 Sep 2016 04:51:25 -0400 Received: from verein.lst.de ([213.95.11.211]:41770 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbcI3IvN (ORCPT ); Fri, 30 Sep 2016 04:51:13 -0400 Date: Fri, 30 Sep 2016 10:51:11 +0200 From: Christoph Hellwig To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v4 09/12] dax: correct dax iomap code namespace Message-ID: <20160930085111.GF19738@lst.de> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475189370-31634-10-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2016 at 04:49:27PM -0600, Ross Zwisler wrote: > The recently added DAX functions that use the new struct iomap data > structure were named iomap_dax_rw(), iomap_dax_fault() and > iomap_dax_actor(). These are actually defined in fs/dax.c, though, so > should be part of the "dax" namespace and not the "iomap" namespace. > Rename them to dax_iomap_rw(), dax_iomap_fault() and dax_iomap_actor() > respectively. > > Signed-off-by: Ross Zwisler > Suggested-by: Dave Chinner I don't really care either way, but this is trivial enought to not introduce a bug, so: Reviewed-by: Christoph Hellwig