From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Fri, 30 Sep 2016 09:55:20 +0000 [thread overview]
Message-ID: <20160930095520.GA10045@mwanda> (raw)
Hello Netanel Belgazal,
The patch 1738cd3ed342: "net: ena: Add a driver for Amazon Elastic
Network Adapters (ENA)" from Aug 10, 2016, leads to the following
static checker warning:
drivers/net/ethernet/amazon/ena/ena_ethtool.c:459 ena_flow_hash_to_flow_type()
warn: bitwise AND condition is false here
drivers/net/ethernet/amazon/ena/ena_ethtool.c
454
455 static u32 ena_flow_hash_to_flow_type(u16 hash_fields)
456 {
457 u32 data = 0;
458
459 if (hash_fields & ENA_ADMIN_RSS_L2_DA)
^^^^^^^^^^^^^^^^^^^
This is zero.
460 data |= RXH_L2DA;
461
462 if (hash_fields & ENA_ADMIN_RSS_L3_DA)
463 data |= RXH_IP_DST;
464
465 if (hash_fields & ENA_ADMIN_RSS_L3_SA)
466 data |= RXH_IP_SRC;
467
468 if (hash_fields & ENA_ADMIN_RSS_L4_DP)
469 data |= RXH_L4_B_2_3;
470
471 if (hash_fields & ENA_ADMIN_RSS_L4_SP)
472 data |= RXH_L4_B_0_1;
473
474 return data;
475 }
regards,
dan carpenter
next reply other threads:[~2016-09-30 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 9:55 Dan Carpenter [this message]
2016-10-12 7:06 ` [bug report] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Dan Carpenter
2016-10-13 16:18 ` Netanel Belgazal
2016-10-13 16:25 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930095520.GA10045@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.