From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] tools/libxc: Don't leak foreign mappings when loading modules
Date: Fri, 30 Sep 2016 11:15:38 +0100 [thread overview]
Message-ID: <20160930101538.GU16004@citrix.com> (raw)
In-Reply-To: <1475229664-10992-1-git-send-email-andrew.cooper3@citrix.com>
On Fri, Sep 30, 2016 at 11:01:03AM +0100, Andrew Cooper wrote:
> Spotted by Coverity
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> tools/libxc/xc_dom_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
> index 5326d36..e177667 100644
> --- a/tools/libxc/xc_dom_core.c
> +++ b/tools/libxc/xc_dom_core.c
> @@ -1119,6 +1119,7 @@ static int xc_dom_load_acpi(struct xc_dom_image *dom)
> }
>
> memcpy(ptr, dom->acpi_modules[i].data, dom->acpi_modules[i].length);
> + munmap(ptr, XC_PAGE_SIZE * num_pages);
>
> free(extents);
> i++;
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-30 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 10:01 [PATCH 1/2] tools/libxc: Don't leak foreign mappings when loading modules Andrew Cooper
2016-09-30 10:01 ` [PATCH 2/2] x86/emulate: Resolve MISSING_BREAK issue in x86_decode() Andrew Cooper
2016-09-30 10:06 ` Jan Beulich
2016-09-30 11:20 ` Wei Liu
2016-09-30 10:15 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930101538.GU16004@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.