From: Johan Hovold <johan@kernel.org>
To: Stas Sergeev <stsp@list.ru>
Cc: Johan Hovold <johan@kernel.org>, Caylan Van Larson <i@caylan.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH] mos7840: fix chars_in_buffer() return value
Date: Fri, 30 Sep 2016 13:04:11 +0200 [thread overview]
Message-ID: <20160930110411.GG5650@localhost> (raw)
In-Reply-To: <5b55f2bb-8936-55bb-597d-68f073ea8620@list.ru>
On Fri, Sep 30, 2016 at 12:00:30AM +0300, Stas Sergeev wrote:
> 29.09.2016 13:09, Johan Hovold пишет:
> > On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
> >> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
> >> a correct behaviour of that.
> >> mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
> >> will return 32.
> >> This patch should fix it by accounting the number of chars actually
> >> written.
> >> This patch, unfortunately, misses the Tested-by tag.
> >> The reporter didn't test it, and I don't have the hardware in question.
> > Why do you think the driver returns 32b in chars_in_buffer after writing
> > a single character?
> Hi Johan, this actually came from this ancient bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=45791
> I was trying to add you back then and now, but your e-mail
> doesn't seem to be registered in a bug tracker.
Yeah, Greg does good job at direction bug reports to the usb mailing
list.
> The code in question was different when I submitted the
> original patch:
> https://bugzilla.kernel.org/attachment.cgi?id=77241
> Maybe the bug was since fixed.
It does seem to have been addressed by commit 5c263b92f828 ("usb:
serial: mos7840: Fixup mos7840_chars_in_buffer()") around the time of
your original report in 2012.
> In that case sorry for the noise.
No worries.
Thanks,
Johan
next prev parent reply other threads:[~2016-09-30 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 15:00 [PATCH] mos7840: fix chars_in_buffer() return value Stas Sergeev
2016-09-29 10:09 ` Johan Hovold
2016-09-29 21:00 ` Stas Sergeev
2016-09-30 11:04 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-24 13:48 Stas Sergeev
2016-09-24 13:47 Stas Sergeev
2016-09-24 13:57 ` Sergei Shtylyov
2016-09-24 15:00 ` Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930110411.GG5650@localhost \
--to=johan@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=i@caylan.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stsp@list.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.