From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 4/5] nvme: use symbolic constants for CNS values
Date: Fri, 30 Sep 2016 11:20:53 -0400 [thread overview]
Message-ID: <20160930152053.GC22601@localhost.localdomain> (raw)
In-Reply-To: <1475236270-18329-5-git-send-email-hch@lst.de>
On Fri, Sep 30, 2016@01:51:09PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/nvme/host/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 329381a..4bade0d 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -554,7 +554,7 @@ int nvme_identify_ctrl(struct nvme_ctrl *dev, struct nvme_id_ctrl **id)
>
> /* gcc-4.4.4 (at least) has issues with initializers and anon unions */
> c.identify.opcode = nvme_admin_identify;
> - c.identify.cns = cpu_to_le32(1);
> + c.identify.cns = cpu_to_le32(NVME_ID_CNS_CTRL);
>
> *id = kmalloc(sizeof(struct nvme_id_ctrl), GFP_KERNEL);
> if (!*id)
> @@ -572,7 +572,7 @@ static int nvme_identify_ns_list(struct nvme_ctrl *dev, unsigned nsid, __le32 *n
> struct nvme_command c = { };
>
> c.identify.opcode = nvme_admin_identify;
> - c.identify.cns = cpu_to_le32(2);
> + c.identify.cns = cpu_to_le32(NVME_ID_CNS_NS_ACTIVE_LIST);
> c.identify.nsid = cpu_to_le32(nsid);
> return nvme_submit_sync_cmd(dev->admin_q, &c, ns_list, 0x1000);
> }
> --
> 2.1.4
next prev parent reply other threads:[~2016-09-30 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 11:51 nvme header updates Christoph Hellwig
2016-09-30 11:51 ` [PATCH 1/5] nvme.h: resync with nvme-cli Christoph Hellwig
2016-09-30 11:51 ` [PATCH 2/5] nvme.h: don't use uuid_be Christoph Hellwig
2016-10-03 16:10 ` J Freyensee
2016-09-30 11:51 ` [PATCH 3/5] nvme.h: add an enum for cns values Christoph Hellwig
2016-09-30 15:19 ` Keith Busch
2016-09-30 11:51 ` [PATCH 4/5] nvme: use symbolic constants for CNS values Christoph Hellwig
2016-09-30 15:20 ` Keith Busch [this message]
2016-09-30 11:51 ` [PATCH 5/5] nvmet: " Christoph Hellwig
2016-10-03 16:09 ` J Freyensee
2016-09-30 13:07 ` nvme header updates Gabriel Krisman Bertazi
2016-10-19 16:53 ` Christoph Hellwig
2016-10-19 17:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930152053.GC22601@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.