From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [Resend PATCH 2/2] Xen/timer: Process softirq during dumping timer info
Date: Fri, 30 Sep 2016 14:11:42 -0400 [thread overview]
Message-ID: <20160930181142.GD23341@char.us.oracle.com> (raw)
In-Reply-To: <1475201946-31898-3-git-send-email-tianyu.lan@intel.com>
On Fri, Sep 30, 2016 at 10:19:06AM +0800, Lan Tianyu wrote:
> Dumping timer info may run for a long time on the huge machine with
> a lot of physical cpus. To avoid triggering NMI watchdog, add
> process_pending_softirqs() in the loop of dumping timer info.
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> ---
> xen/common/timer.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xen/common/timer.c b/xen/common/timer.c
> index 29a60a9..ab6bca0 100644
> --- a/xen/common/timer.c
> +++ b/xen/common/timer.c
> @@ -530,6 +530,7 @@ static void dump_timerq(unsigned char key)
> {
> ts = &per_cpu(timers, i);
>
> + process_pending_softirqs();
> printk("CPU%02d:\n", i);
> spin_lock_irqsave(&ts->lock, flags);
> for ( j = 1; j <= GET_HEAP_SIZE(ts->heap); j++ )
> --
> 1.7.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-30 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 2:19 [Resend PATCH 0/2] Xen: Fix Xen hypervisor panic during dumping timer info on huge machine Lan Tianyu
2016-09-30 2:19 ` [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet Lan Tianyu
2016-09-30 18:07 ` Konrad Rzeszutek Wilk
2016-10-08 3:17 ` Lan Tianyu
2016-10-06 12:52 ` Jan Beulich
2016-10-08 3:26 ` Lan Tianyu
2016-10-10 6:48 ` Jan Beulich
2016-10-10 13:55 ` Konrad Rzeszutek Wilk
2016-10-11 1:42 ` Lan Tianyu
2016-09-30 2:19 ` [Resend PATCH 2/2] Xen/timer: Process softirq during dumping timer info Lan Tianyu
2016-09-30 18:11 ` Konrad Rzeszutek Wilk [this message]
2016-10-06 12:56 ` Jan Beulich
2016-10-08 5:28 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930181142.GD23341@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tianyu.lan@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.