Re: [Qemu-devel] [PATCH v3 00/15] A number of fixes for ThreadSanitizer

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20160930213106.20186-1-alex.bennee@linaro.org
Subject: [Qemu-devel] [PATCH v3 00/15] A number of fixes for ThreadSanitizer

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1475246744-29302-1-git-send-email-berrange@redhat.com -> patchew/1475246744-29302-1-git-send-email-berrange@redhat.com
 * [new tag]         patchew/20160930213106.20186-1-alex.bennee@linaro.org -> patchew/20160930213106.20186-1-alex.bennee@linaro.org
Switched to a new branch 'test'
4f429c2 translate-all: mark updates to PageDesc as atomic
d6cfc0a tcg: update remaining TranslationBuffer fields atomically
831c9b0 tcg: ensure cpu_tb_exec/tb_gen_code use atomic_read/write
f0c76b4 .travis.yml: add gcc sanitizer build
27926c7 qga/command: use QEMU atomic primitives
7b7d449 linux-user/syscall: extend lock around cpu-list
9659c21 util/qht: atomically set b->hashes
e5625e0 cpu: atomically modify cpu->exit_request
1a2afa5 qom/cpu: atomically clear the tb_jmp_cache
857940f qom/object: update class cache atomically
d0019b1 seqlock: use atomic writes for the sequence
58cdc77 tcg/optimize: move default return out of if statement
35c6de8 exec-all.h: revert tb_page_addr_t to target_ulong
ec4be39 atomic.h: comment on use of atomic_read/set
0f57650 atomic.h: fix __SANITIZE_THREAD__ build

=== OUTPUT BEGIN ===
Checking PATCH 1/15: atomic.h: fix __SANITIZE_THREAD__ build...
Checking PATCH 2/15: atomic.h: comment on use of atomic_read/set...
Checking PATCH 3/15: exec-all.h: revert tb_page_addr_t to target_ulong...
Checking PATCH 4/15: tcg/optimize: move default return out of if statement...
Checking PATCH 5/15: seqlock: use atomic writes for the sequence...
Checking PATCH 6/15: qom/object: update class cache atomically...
Checking PATCH 7/15: qom/cpu: atomically clear the tb_jmp_cache...
Checking PATCH 8/15: cpu: atomically modify cpu->exit_request...
Checking PATCH 9/15: util/qht: atomically set b->hashes...
Checking PATCH 10/15: linux-user/syscall: extend lock around cpu-list...
Checking PATCH 11/15: qga/command: use QEMU atomic primitives...
Checking PATCH 12/15: .travis.yml: add gcc sanitizer build...
Checking PATCH 13/15: tcg: ensure cpu_tb_exec/tb_gen_code use atomic_read/write...
ERROR: line over 90 characters
#38: FILE: cpu-exec.c:294:
+    if (unlikely(!tb || atomic_read(&tb->pc) != pc || atomic_read(&tb->cs_base) != cs_base ||

total: 1 errors, 0 warnings, 32 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/15: tcg: update remaining TranslationBuffer fields atomically...
Checking PATCH 15/15: translate-all: mark updates to PageDesc as atomic...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org