From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcJADnn (ORCPT ); Fri, 30 Sep 2016 23:43:43 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:62741 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcJADne (ORCPT ); Fri, 30 Sep 2016 23:43:34 -0400 From: Arnd Bergmann To: Ido Schimmel Subject: Re: [PATCH 2/2] mlxsw: spectrum_router: avoid potential uninitialized data usage Date: Sat, 1 Oct 2016 05:36:30 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: Jiri Pirko , Ido Schimmel , "David S. Miller" , Yotam Gigi , Nogah Frankel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160930161734.70928-1-arnd@arndb.de> <20160930161734.70928-2-arnd@arndb.de> <20160930175700.GA641@splinter> In-Reply-To: <20160930175700.GA641@splinter> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201610010536.30927.arnd@arndb.de> X-Provags-ID: V03:K0:gHc+qElx74m9e66eu74vIxxUyOngu4iD2ntGnnE7TlllkytTHR4 zV1f720p2P3kiw+DAN1Uxi1i/eH9QwVw8Tc1VPT8lUHa78MPqCJ8gnxXDlrMXHE2z+7zeUk EkL75n3B9hDLGdIIY1oNq+3rWwzViE0mQxwAG2LHdv+ZWZzqIX0Ay+wtEBhHVi5kpgpUw6c GwqcbV+ac54PgHx0ur7IQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:VO58c5iNw9A=:/riwaXKBf/2LbXcMsyapnX pWk9rFfyozfTss4MbqrDKG5taWbeTbwN9Kj2bfpOtFvgxo2P/yGTMlHFcdDrwo7OVCLnY4CS+ 6uRgNopdAgYuvZYso5c6MSL2Y0+viADDtLb+6X7u6CbqbRzIRm6KrR21aRlyZkDf4MFlPl9pd Ync2TlKXH5URo/k3H4rJE49VKafUYFbVHZdsZPvPULhZaxwQjjrdHNSEk4V2sCwrCRojJw4H1 C4WmfsM+aE68DAnwjqo234ZOUKCy4z+hskSksyKhV4Brbg+zOEGsqoEbVFoXFMSy9YKI+FGXA 9VA2kh/4vGTBbVPzW1v7mhRUlg2FqUw6GZIvUVIoI8fzJQxc4/7G3juOFoWZpxX2pAjxWZZkG bYqPAtDE5EZSRSnWU1+zNSsNRcTJ6KI1e+AgDte81xxGwV14uDqa0gg3sCpLR2YRAaW/EbKiS AOfV08vCuS/WpZzbtpJuo6NQLTPf/nuO6yhVIKu+/8ho2Q3FrIbR0csN916OJTCHnfK/kxMsD 1Q9VZT0WryfQJMc2B+N2pG1QWOwNkEs9zb2Qo9CzHg5yo2HN0qNaTtw9TZCboTofCt/NbnaVt oGO87rMhkBICHIAyMGjZVxXYMcqM8aHrC45Lv1mypN/v++mTFMB77cpK0a2ewM1CJRJGLnUf0 mrE42o145dSymWDcZhsi59wojl90DLKQlxX+QZi0Aa7WJEUaGxO8jXg+harT8Ji9D72ZQfE7i K/9NhmxtSHNRsUlb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 September 2016, Ido Schimmel wrote: > BTW, which flags did you pass to generate this error? I can only > reproduce this with EXTRA_CFLAGS="-Wmaybe-uninitialized -Werror", but > for some reason EXTRA_CFLAGS="-Wall -Werror" is silent. Any idea why? I > would like to add this to my git hooks and avoid these errors in the > future :) Linus disabled the warning for v4.8. I've just talked to him today about this warning in particular, and hope that we can find a way to enable it by default again in the future, as a lot of possible bugs get introduced, but certain compiler versions also produce a lot of false positives. Arnd