From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sun, 02 Oct 2016 09:47:47 +0000 Subject: Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c Message-Id: <20161002094747.GA27462@kroah.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Moshe Green Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > Rename CamelCased macro roundedDiv to rounded_div. > > This issue was found by checkpatch.pl > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 3a0afe1..e4efe91 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -7,7 +7,7 @@ > #include "ddk750_power.h" > > /* n / d + 1 / 2 = (2n + d) / 2d */ > -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) > +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) Shouldn't you use the in-kernel function for this instead? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbcJBJrs (ORCPT ); Sun, 2 Oct 2016 05:47:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57775 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbcJBJrr (ORCPT ); Sun, 2 Oct 2016 05:47:47 -0400 Date: Sun, 2 Oct 2016 11:47:47 +0200 From: Greg KH To: Moshe Green Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c Message-ID: <20161002094747.GA27462@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > Rename CamelCased macro roundedDiv to rounded_div. > > This issue was found by checkpatch.pl > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 3a0afe1..e4efe91 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -7,7 +7,7 @@ > #include "ddk750_power.h" > > /* n / d + 1 / 2 = (2n + d) / 2d */ > -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) > +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom))) Shouldn't you use the in-kernel function for this instead?