All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Rehas Sachdeva <aquannie@gmail.com>,
	outreachy-kernel@googlegroups.com,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>
Subject: Re: [Outreachy kernel] [PATCH] staging: lustre: Constify kernel_param_ops structures
Date: Sun, 2 Oct 2016 12:28:17 +0200	[thread overview]
Message-ID: <20161002102817.GA18602@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610011911530.3445@hadrien>

On Sat, Oct 01, 2016 at 07:13:16PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 1 Oct 2016, Rehas Sachdeva wrote:
> 
> > Check for structs which can are not modified and hence can be declared as
> > const. Done using Coccinelle:
> 
> "can are" -> "are"
> 
> This merits a little more discussion, though.  I have the impression that
> these structures are used via the module_param macro.  It would be useful
> to look at the expansion of the macros and see what exactly is going on.

Based on other uses of this structure in the kernel, I think this is
safe.  But verification would be good...

thanks,

greg k-h


  parent reply	other threads:[~2016-10-02 10:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-01 17:05 [PATCH] staging: lustre: Constify kernel_param_ops structures Rehas Sachdeva
2016-10-01 17:13 ` [Outreachy kernel] " Julia Lawall
2016-10-01 17:27   ` Rehas Sachdeva
2016-10-02 10:28   ` Greg Kroah-Hartman [this message]
2016-10-02 12:58     ` [Outreachy kernel] " Rehas Sachdeva
2016-10-02 14:17       ` Julia Lawall
2016-10-02 18:20         ` Rehas Sachdeva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161002102817.GA18602@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=aquannie@gmail.com \
    --cc=jsimmons@infradead.org \
    --cc=julia.lawall@lip6.fr \
    --cc=oleg.drokin@intel.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.