From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqcAq-0003KE-Fd for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:31:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqcAk-0000xC-G2 for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:31:03 -0400 Received: from 1.mo177.mail-out.ovh.net ([178.33.107.143]:56623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqcAk-0000x4-A5 for qemu-devel@nongnu.org; Sun, 02 Oct 2016 04:30:58 -0400 Received: from player779.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id 3D13CFF9AC0 for ; Sun, 2 Oct 2016 10:30:57 +0200 (CEST) Date: Sun, 2 Oct 2016 10:30:51 +0200 From: Greg Kurz Message-ID: <20161002103051.4aa295c6@bahia> In-Reply-To: <1475348164-8593-2-git-send-email-lvivier@redhat.com> References: <1475348164-8593-1-git-send-email-lvivier@redhat.com> <1475348164-8593-2-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/5] tests: fix memory leak in virtio-scsi-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, dgibson@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org On Sat, 1 Oct 2016 20:56:00 +0200 Laurent Vivier wrote: > vs is allocated in qvirtio_scsi_pci_init() and never freed. > > Signed-off-by: Laurent Vivier > --- Reviewed-by: Greg Kurz > tests/virtio-scsi-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c > index 79088bb..94d75b1 100644 > --- a/tests/virtio-scsi-test.c > +++ b/tests/virtio-scsi-test.c > @@ -64,6 +64,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs) > qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev)); > g_free(vs->dev); > qpci_free_pc(vs->bus); > + g_free(vs); > } > > static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,