From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbcJBPYD (ORCPT ); Sun, 2 Oct 2016 11:24:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60108 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbcJBPXz (ORCPT ); Sun, 2 Oct 2016 11:23:55 -0400 Date: Sun, 2 Oct 2016 17:23:55 +0200 From: Greg KH To: Nadim Almas Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue Message-ID: <20161002152355.GB32091@kroah.com> References: <20160930214912.GA6932@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160930214912.GA6932@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote: > Fixed coding style issue. > > Signed-off-by: Nadim Almas > --- > drivers/staging/dgnc/dgnc_neo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index e794056..bc15584 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port) > * Rx Oruns. Exar says that an orun will NOT corrupt > * the FIFO. It will just replace the holding register > * with this new data byte. So basically just ignore this. > - * Probably we should eventually have an orun stat in our driver... > + * Probably we should eventually have an orun stat in our > + * driver... > */ > ch->ch_err_overrun++; > } Why did you just fix only one of these warnings in the file? You aren't going to send one patch per instance of this warning in this file, are you? Please group it all into one. thanks, greg k-h