From: Greg KH <gregkh@linuxfoundation.org>
To: Anchal Jain <anchalj109@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal
Date: Sun, 2 Oct 2016 17:34:17 +0200 [thread overview]
Message-ID: <20161002153417.GA20682@kroah.com> (raw)
In-Reply-To: <20160930165233.GA4907@life-desktop>
On Fri, Sep 30, 2016 at 10:22:48PM +0530, Anchal Jain wrote:
> Replace memcmp() with ether_addr_equal()
> issue detect by checkpatch.pl
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
You didn't build test this patch, which isn't very nice :(
Please always test your patches by at least building them, otherwise you
will end up with grumpy maintainers...
greg k-h
prev parent reply other threads:[~2016-10-02 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 16:52 [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal Anchal Jain
2016-10-02 15:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002153417.GA20682@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anchalj109@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.