All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anchal Jain <anchalj109@gmail.com>
Cc: jic23@kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v4 ] staging: iio: cdc: ad7150: add comment to mutex
Date: Sun, 2 Oct 2016 17:40:39 +0200	[thread overview]
Message-ID: <20161002154039.GB21118@kroah.com> (raw)
In-Reply-To: <20161002153424.GA4211@life-desktop>

On Sun, Oct 02, 2016 at 09:04:43PM +0530, Anchal Jain wrote:
> Add a comment in mutex to explain what the mutex is work here.
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>  drivers/staging/iio/cdc/ad7150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index f6b9a10..13709bf 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -78,7 +78,7 @@ struct ad7150_chip_info {
>  	u8 mag_timeout[2][2];
>  	int old_state;
>  	char *conversion_mode;
> -	struct mutex state_lock;
> +	struct mutex state_lock; /* protect hardware state */

I think I need to just not take any of these types of patches, as it's
not exactly a good thing for someone who does not understand the driver
to be able to fix up.

Just ignore these warnings for now please.

thanks,

greg k-h


  reply	other threads:[~2016-10-02 15:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 15:34 [PATCH v4 ] staging: iio: cdc: ad7150: add comment to mutex Anchal Jain
2016-10-02 15:40 ` Greg KH [this message]
2016-10-02 15:45   ` Anchal Jain
2016-10-02 15:53     ` [Outreachy kernel] " Julia Lawall
2016-10-02 16:21       ` Anchal Jain
2016-10-02 18:16         ` Alison Schofield
2016-10-02 18:25           ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161002154039.GB21118@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anchalj109@gmail.com \
    --cc=jic23@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.