Re: [PATCH v2] staging: rtl8188eu: core: rtw_ap: Replace memcmp() with ether_addr_equal()

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Oct 02, 2016 at 06:11:20PM +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 09:34:17PM +0530, Anchal Jain wrote:
> > When comparing MAC addresses, use ether_addr_equal instead of memcmp to
> > ETH_ALEN length.
> > 
> > Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> > ---
> >  drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> > index fbe9941..6a3dc5e 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> > @@ -1163,7 +1163,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
> >  		paclnode = container_of(plist, struct rtw_wlan_acl_node, list);
> >  		plist = plist->next;
> >  
> > -		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> > +		if (!ether_addr_equal(paclnode->addr, addr)) {
> >  			if (paclnode->valid) {
> >  				added = true;
> >  				DBG_88E("%s, sta has been added\n", __func__);
> > @@ -1223,7 +1223,7 @@ int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
> >  		paclnode = container_of(plist, struct rtw_wlan_acl_node, list);
> >  		plist = plist->next;
> >  
> > -		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> > +		if (!ether_addr_equal(paclnode->addr, addr, ETH_ALEN)) {
> >  			if (paclnode->valid) {
> >  				paclnode->valid = false;
> >  
> > -- 
> > 1.9.1
> 
> I don't see a change here that will fix the build warnings, what did you
> do differently from version 1?
> 
> Always put that information in the patch, below the --- line, as it is
> described in Documentation/SubmittingPatches

Also, you didn't test this, why not?  That's a bit rude to not do so,
don't you think?