From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/3] gpio: acpi: separation of concerns
Date: Mon, 3 Oct 2016 13:24:46 +0300 [thread overview]
Message-ID: <20161003102446.GA1218@lahna.fi.intel.com> (raw)
In-Reply-To: <1475485360-15127-2-git-send-email-linus.walleij@linaro.org>
On Mon, Oct 03, 2016 at 11:02:39AM +0200, Linus Walleij wrote:
> The generic GPIO library directly implement code for acpi_find_gpio()
> which is only used with CONFIG_ACPI. This was probably done because
> OF did the same thing, but I removed that so remove this too.
Yes, it was originally copied from the DT implementation.
> Rename the internal acpi_find_gpio() in gpiolib-acpi.c to
> acpi_populate_gpio_lookup() which seems to be more appropriate anyway
> so as to avoid a namespace clash with the same function.
>
> Make the stub return -ENOENT rather than -ENOSYS (as that is for
> syscalls!).
-ENXIO?
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Regardless of that,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-10-03 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 9:02 [PATCH 1/3] gpio: OF: separation of concerns Linus Walleij
2016-10-03 9:02 ` [PATCH 2/3] gpio: acpi: " Linus Walleij
2016-10-03 10:24 ` Mika Westerberg [this message]
2016-10-03 12:36 ` Linus Walleij
2016-10-03 12:44 ` Mika Westerberg
2016-10-03 9:02 ` [PATCH 3/3] gpio: OF: localize some gpiochip init functions Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003102446.GA1218@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.