From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output
Date: Mon, 3 Oct 2016 11:31:38 -0400 [thread overview]
Message-ID: <20161003153137.GA19245@bfoster.bfoster> (raw)
In-Reply-To: <4074f575-f4cf-e8ee-7c79-0bbc45333f5d@redhat.com>
On Thu, Sep 08, 2016 at 04:53:28PM -0500, Eric Sandeen wrote:
> When XBF_NO_IOACCT got added, it missed the translation
> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
> than the flag name. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Thought I caught that, apparently not. Thanks!
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
> index 1c2e52b..424f6b0 100644
> --- a/fs/xfs/xfs_buf.h
> +++ b/fs/xfs/xfs_buf.h
> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
> { XBF_READ, "READ" }, \
> { XBF_WRITE, "WRITE" }, \
> { XBF_READ_AHEAD, "READ_AHEAD" }, \
> + { XBF_NO_IOACCT, "NO_IOACCT" }, \
> { XBF_ASYNC, "ASYNC" }, \
> { XBF_DONE, "DONE" }, \
> { XBF_STALE, "STALE" }, \
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-03 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 21:53 [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output Eric Sandeen
2016-10-03 15:01 ` Eric Sandeen
2016-10-03 15:31 ` Brian Foster [this message]
2016-11-10 16:41 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003153137.GA19245@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.