All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array
Date: Mon, 3 Oct 2016 16:10:55 -0300	[thread overview]
Message-ID: <20161003191055.GF3877@thinpad.lan.raisama.net> (raw)
In-Reply-To: <20161003164236.GN13491@redhat.com>

On Mon, Oct 03, 2016 at 05:42:36PM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 27, 2016 at 05:12:24PM -0300, Eduardo Habkost wrote:
> > This will reuse the existing check/enforce logic in
> > x86_cpu_filter_features() to check the xsave component bits
> > against GET_SUPPORTED_CPUID.
> > 
> > Reviewed-by: Richard Henderson <rth@twiddle.net>
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  target-i386/cpu.c | 42 ++++++++++++++++++++++++++++--------------
> >  target-i386/cpu.h |  3 ++-
> >  2 files changed, 30 insertions(+), 15 deletions(-)
> 
> git bisect tells me that this change is responsible for breaking booting
> of a guest of mine which uses -cpu host
> 
> GRUB works, but the guest kernel hangs immediately after printing
> 
> "Probing EDD (edd=off to disable)... ok"
> 
> Removing '-cpu host' lets it work again.
[...]
> In case its relevant, QEMU prints this to stderr:
> 
> warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 0]
> warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 1]
> warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 2]

This was reported by Wanpeng Li last week. The fix ("target-i386:
Report known CPUID[EAX=0xD,ECX=0]:EAX bits as migratable") is in
the pull request I sent today.

You can also work around it by using "-cpu host,migratable=off".

-- 
Eduardo

  reply	other threads:[~2016-10-03 19:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 20:12 [Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27 Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 01/20] target-i386: Remove unused X86CPUDefinition::xlevel2 field Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 02/20] target-i386: Add a marker to end of the region zeroed on reset Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 03/20] tests: Add test code for CPUID level/xlevel handling Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 04/20] tests: Test CPUID level handling for old machines Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 05/20] target-i386: Automatically set level/xlevel/xlevel2 when needed Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 06/20] target-i386: Enable CPUID[0x8000000A] if SVM is enabled Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 07/20] linux-user: remove #define smp_{cores, threads} Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 08/20] target-i386: Move feature name arrays inside FeatureWordInfo Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 09/20] target-i386: Don't try to enable PT State xsave component Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 10/20] target-i386: xsave: Calculate enabled components only once Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 11/20] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 12/20] target-i386: xsave: Helper function to calculate xsave area size Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 13/20] target-i386: xsave: Calculate set of xsave components on realize Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array Eduardo Habkost
2016-10-03 16:42   ` Daniel P. Berrange
2016-10-03 19:10     ` Eduardo Habkost [this message]
2016-09-27 20:12 ` [Qemu-devel] [PULL 15/20] target-i386: Remove has_msr_mtrr global variable Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 16/20] target-i386: Remove has_msr_hv_apic " Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 17/20] target-i386: Remove has_msr_hv_tsc " Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 18/20] target-i386: Clear KVM CPUID features if KVM is disabled Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 19/20] target-i386: Remove has_msr_* global vars for KVM features Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 20/20] sysbus: Remove ignored return value of FindSysbusDeviceFunc Eduardo Habkost
2016-09-27 23:31 ` [Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003191055.GF3877@thinpad.lan.raisama.net \
    --to=ehabkost@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.