From: Stephen Boyd <sboyd@codeaurora.org>
To: kgunda@codeaurora.org
Cc: Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel@vger.kernel.org, aghayal@qti.qualcomm.com,
adharmap@codeaurora.org
Subject: Re: [PATCH] spmi: regmap: enable userspace writes
Date: Mon, 3 Oct 2016 14:03:50 -0700 [thread overview]
Message-ID: <20161003210350.GB8871@codeaurora.org> (raw)
In-Reply-To: <128966d05cff74d2da786abfb0404071@codeaurora.org>
On 09/30, kgunda@codeaurora.org wrote:
> On 2016-09-29 23:30, Mark Brown wrote:
> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> >
> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
> >
> >This is completely inappropriate for upstream, if you need to do
> >debugging on your platform you can enable this locally but enabling
> >random writes from userspace to any regmap device is really not a good
> >idea for system stablity or robustness.
>
> Sure. I will remove this change and send the next version only to update
> the spmi device name.
Why? The device name looks fine.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-03 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 11:36 [PATCH] spmi: regmap: enable userspace writes Kiran Gunda
2016-09-29 18:00 ` Mark Brown
2016-09-30 5:07 ` kgunda
2016-10-03 21:03 ` Stephen Boyd [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-06 10:10 kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003210350.GB8871@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=aghayal@qti.qualcomm.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgunda@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.