From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brOVY-0001iz-54 for qemu-devel@nongnu.org; Tue, 04 Oct 2016 08:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brOVS-0007LR-MF for qemu-devel@nongnu.org; Tue, 04 Oct 2016 08:07:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brOVS-0007Ko-Ew for qemu-devel@nongnu.org; Tue, 04 Oct 2016 08:07:34 -0400 Date: Tue, 4 Oct 2016 13:07:28 +0100 From: "Daniel P. Berrange" Message-ID: <20161004120728.GH5578@redhat.com> Reply-To: "Daniel P. Berrange" References: <1475580648-6470-1-git-send-email-lvivier@redhat.com> <20161004120046.yklur3w7i7e7yhm4@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161004120046.yklur3w7i7e7yhm4@kamzik.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] introduce "accel=best" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Stefano Stabellini , "Michael S . Tsirkin" , qemu-devel@nongnu.org, Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= On Tue, Oct 04, 2016 at 02:00:46PM +0200, Andrew Jones wrote: > On Tue, Oct 04, 2016 at 01:30:46PM +0200, Laurent Vivier wrote: > > This series introduces a new parameter to "accel" to > > ask to use the best one. > > > > This allows to remove ugly "kvm accelerator not found" > > from the "make check" logs. > > > > Laurent Vivier (2): > > accel: allows to select the "best" accelerator > > tests: use accel=best instead of accel=kvm:tcg > > > > accel.c | 58 ++++++++++++++++++++++++++++++++++++++++-------- > > include/sysemu/accel.h | 1 + > > kvm-all.c | 1 + > > qemu-options.hx | 4 +++- > > qtest.c | 1 + > > tests/bios-tables-test.c | 2 +- > > tests/postcopy-test.c | 8 +++---- > > xen-common.c | 1 + > > 8 files changed, 61 insertions(+), 15 deletions(-) > > How about probing the host for KVM in the tests. When it's > available, then only emit accel=kvm. When it's not (and > it's OK to fallback to tcg), then emit only accel=tcg. > That's what we do in kvm-unit-tests. Arguably unit tests should not have any dependancy on the host hardware, and should be using accel=tcg exclusively, so that they have stable and predictable behaviour for all developers. Only functional / integration tests should have dependancies on host hardware/OS, so where accel=kvm would be appropriate. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|