From: Marcelo Cerri <marcelo.cerri@canonical.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
George Wilson <gcwilson@us.ibm.com>,
Claudio Carvalho <cclaudio@br.ibm.com>,
Paulo Flabiano Smorigo <pfsmorigo@br.ibm.com>,
joy.latten@canonical.com, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: sha1-powerpc: little-endian support
Date: Tue, 4 Oct 2016 09:07:37 -0300 [thread overview]
Message-ID: <20161004120737.GA16223@gallifrey> (raw)
In-Reply-To: <87pong4oq3.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
Hi Michael,
On Ubuntu, CRYPTO_MANAGER_DISABLE_TESTS is set by default. So I had to
disable this config in order to make sha1-powerpc fail in the crypto API
tests. However, even with tests disabled, any usage of sha1-powerpc
should result in incorrect results.
--
Regards,
Marcelo
On Tue, Oct 04, 2016 at 05:23:16PM +1100, Michael Ellerman wrote:
> Marcelo Cerri <marcelo.cerri@canonical.com> writes:
>
> > [ Unknown signature status ]
> > On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote:
> >> On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote:
> >> > Hi Herbert,
> >> >
> >> > Any thoughts on this one?
> >>
> >> Can this patch wait until the next merge window? On the broken
> >> platforms it should just fail the self-test, right?
> >
> > Yes. It fails on any LE platform (including Ubuntu and RHEL 7.1).
>
> How are you testing this? I thought I was running the crypto tests but
> I've never seen this fail.
>
> cheers
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-10-04 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 19:31 [PATCH] crypto: sha1-powerpc: little-endian support Marcelo Cerri
2016-09-27 0:46 ` Paulo Flabiano Smorigo
2016-09-28 13:15 ` Marcelo Cerri
2016-09-28 13:20 ` Herbert Xu
2016-09-28 13:27 ` Marcelo Cerri
2016-10-04 6:23 ` Michael Ellerman
2016-10-04 12:07 ` Marcelo Cerri [this message]
2016-10-02 14:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004120737.GA16223@gallifrey \
--to=marcelo.cerri@canonical.com \
--cc=benh@kernel.crashing.org \
--cc=cclaudio@br.ibm.com \
--cc=davem@davemloft.net \
--cc=gcwilson@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=joy.latten@canonical.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pfsmorigo@br.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.