From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbcJDTtd (ORCPT ); Tue, 4 Oct 2016 15:49:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36818 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbcJDTtc (ORCPT ); Tue, 4 Oct 2016 15:49:32 -0400 Date: Tue, 4 Oct 2016 21:49:32 +0200 From: Greg KH To: Vijay Kumar Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb/core: Added devspec sysfs entry for devices behind usb hub Message-ID: <20161004194932.GA28726@kroah.com> References: <1475607880-105300-1-git-send-email-vijay.ac.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475607880-105300-1-git-send-email-vijay.ac.kumar@oracle.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2016 at 12:04:40PM -0700, Vijay Kumar wrote: > Grub finds incorrect of_node path for devices behind usb hub. > Added devspec sysfs entry for devices behind usb hub so that > right of_node path is returned during grub sysfs walk for these > devices. > > Signed-off-by: Vijay Kumar > > --- > drivers/usb/core/sysfs.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c > index c953a0f..84d66d5 100644 > --- a/drivers/usb/core/sysfs.c > +++ b/drivers/usb/core/sysfs.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include "usb.h" > > /* Active configuration fields */ > @@ -104,6 +105,17 @@ static ssize_t bConfigurationValue_store(struct device *dev, > static DEVICE_ATTR_IGNORE_LOCKDEP(bConfigurationValue, S_IRUGO | S_IWUSR, > bConfigurationValue_show, bConfigurationValue_store); > > +#ifdef CONFIG_OF > +static ssize_t devspec_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + struct device_node *of_node = dev->of_node; > + > + return sprintf(buf, "%s\n", of_node_full_name(of_node)); > +} > +static DEVICE_ATTR_RO(devspec); > +#endif Any way to do this without the #ifdef? And you need to also update Documentation/ABI if you add a new sysfs file. thanks, greg k-h