From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1brVjL-0008NX-VT
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 15:50:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1brVjJ-0007eU-S1
	for qemu-devel@nongnu.org; Tue, 04 Oct 2016 15:50:22 -0400
Date: Tue, 4 Oct 2016 15:50:13 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20161004195013.GC21979@localhost.localdomain>
References: <b9f2ee7dbaf07f1d3e683424ec71a9dcd84616d0.1475601618.git.jcody@redhat.com>
	<854900cc-128b-5690-9fe9-a479807fae45@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <854900cc-128b-5690-9fe9-a479807fae45@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with
 correct output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, Markus Armbruster <armbru@redhat.com>

On Tue, Oct 04, 2016 at 02:48:41PM -0500, Eric Blake wrote:
> On 10/04/2016 12:22 PM, Jeff Cody wrote:
> > Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
> > dispatch and validation code, and the error output that test
> > 085 relied on changed.  Update it to be correct.
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> >  tests/qemu-iotests/085.out | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Doesn't Marc-Andre's regression-fix followup patch series change the
> wording right back, so that we wouldn't need this fix?
> 
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08088.html
> 

Ah, yes - thanks.  Please ignore this patch :)

> > 
> > diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
> > index 08e4bb7..7a36117 100644
> > --- a/tests/qemu-iotests/085.out
> > +++ b/tests/qemu-iotests/085.out
> > @@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2 size=134217728 backing_file
> >  
> >  === Invalid command - missing snapshot-file ===
> >  
> > -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is missing"}}
> > +{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'snapshot-file', expected: string"}}
> >  
> >  
> >  === Create several transactional group snapshots ===
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>