From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH] efi/arm: fix absolute relocation detection for older toolchains Date: Tue, 4 Oct 2016 22:30:45 +0100 Message-ID: <20161004213045.GT16071@codeblueprint.co.uk> References: <1475276515-21801-1-git-send-email-ard.biesheuvel@linaro.org> <20161003205233.GO16071@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Russell King - ARM Linux , Kevin Hilman , Olof Johansson List-Id: linux-efi@vger.kernel.org On Tue, 04 Oct, at 11:34:31AM, Ard Biesheuvel wrote: > > These relocations are harmless, since the debug ones are only > interpreted by the debugger, and the ones generated by > EXPORT_SYMBOL(sort) will never be referenced, since the symbols they > contain are either renamed to __efistub_xxx (arm64), or they are not > part of the kernel proper (arm) > > So both cases are false positives, but the diagnostic is important, > and so breaking the build is appropriate for any other absolute > relocation that may appear. > > The effect of the patch is not that the diagnostic is ignored, but > that these relocations are not generated in the first place (-g0) or > removed explicitly (ksymtab/krcrctab+sort) rather than via a wildcard. > So other than not breaking the build, this patch should have no user > observeable differences. Thanks Ard, sounds reasonable. Feel free to take this through whichever tree you think is best. Reviewed-by: Matt Fleming From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@codeblueprint.co.uk (Matt Fleming) Date: Tue, 4 Oct 2016 22:30:45 +0100 Subject: [PATCH] efi/arm: fix absolute relocation detection for older toolchains In-Reply-To: References: <1475276515-21801-1-git-send-email-ard.biesheuvel@linaro.org> <20161003205233.GO16071@codeblueprint.co.uk> Message-ID: <20161004213045.GT16071@codeblueprint.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 04 Oct, at 11:34:31AM, Ard Biesheuvel wrote: > > These relocations are harmless, since the debug ones are only > interpreted by the debugger, and the ones generated by > EXPORT_SYMBOL(sort) will never be referenced, since the symbols they > contain are either renamed to __efistub_xxx (arm64), or they are not > part of the kernel proper (arm) > > So both cases are false positives, but the diagnostic is important, > and so breaking the build is appropriate for any other absolute > relocation that may appear. > > The effect of the patch is not that the diagnostic is ignored, but > that these relocations are not generated in the first place (-g0) or > removed explicitly (ksymtab/krcrctab+sort) rather than via a wildcard. > So other than not breaking the build, this patch should have no user > observeable differences. Thanks Ard, sounds reasonable. Feel free to take this through whichever tree you think is best. Reviewed-by: Matt Fleming