Re: [PATCH 1/2] MIPS: tracing: move insn_has_delay_slot to a shared header

[Ralf Baechle <ralf@linux-mips.org>]

On Fri, Sep 30, 2016 at 11:33:45AM +0200, Marcin Nowakowski wrote:

> Currently both kprobes and uprobes code have definitions of the
> insn_has_delay_slot method. Move it to a separate header as an inline
> method that each probe-specific method can later use.
> No functional change intended, although the methods slightly varied in
> the constraints they set for the methods - the uprobes one was chosen as
> it is slightly more specific when filtering opcode fields.

Applied - but this is way to big for an inline function and will end up
getting expanded two times in uprobes.c for no good reason.  I think this
function should become go to something like arch/mips/kernel/branch.c -
or maybe a helper library like arch/mips/lib/bdelay.c.

  Ralf