All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Stefan Christ <contact@stefanchrist.eu>
Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
Date: Wed, 5 Oct 2016 11:00:03 +0200	[thread overview]
Message-ID: <20161005090003.GB21711@joana> (raw)
In-Reply-To: <1475616960-19527-1-git-send-email-contact@stefanchrist.eu>

Hi Stefan,

2016-10-04 Stefan Christ <contact@stefanchrist.eu>:

> The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> implementations for functions in struct fb_ops. A drm driver can use it
> like:
> 
>     static struct fb_ops drm_fbdev_cma_ops = {
>         .owner          = THIS_MODULE,
>         DRM_FB_HELPER_DEFAULT_OPS,
>         /* driver specific implementations */
>     };
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> ---
> v2: Fix sphinx error:
>      warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
> ---
>  include/drm/drm_fb_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index db8d478..f7d7126 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -214,6 +214,19 @@ struct drm_fb_helper {
>  	bool delayed_hotplug;
>  };
>  
> +/**
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers

If I'm not mistaken v1 of this patch is already in drm-misc so you may
want to send a patch that fix just the line above.

Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-10-05  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 15:18 [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS: kbuild test robot
2016-10-03  9:35 ` Jani Nikula
2016-10-03 13:50   ` [Intel-gfx] " Daniel Vetter
2016-10-04 21:36     ` [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops Stefan Christ
2016-10-05  9:00       ` Gustavo Padovan [this message]
2016-10-05 13:13         ` Daniel Vetter
2016-10-05 18:34           ` [PATCH] drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS Stefan Christ
2016-10-06  9:18             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005090003.GB21711@joana \
    --to=gustavo@padovan.org \
    --cc=contact@stefanchrist.eu \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.