From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbcJELQy (ORCPT ); Wed, 5 Oct 2016 07:16:54 -0400 Received: from mail.kernel.org ([198.145.29.136]:45882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbcJELQx (ORCPT ); Wed, 5 Oct 2016 07:16:53 -0400 Date: Wed, 5 Oct 2016 08:16:36 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode Message-ID: <20161005111636.GP7143@kernel.org> References: <1475062896-22274-1-git-send-email-adrian.hunter@intel.com> <43aa0250-fe84-f70a-8995-04af72c584f9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43aa0250-fe84-f70a-8995-04af72c584f9@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 05, 2016 at 10:33:14AM +0300, Adrian Hunter escreveu: > On 28/09/16 14:41, Adrian Hunter wrote: > > In cycle-accurate mode, timestamps can be calculated from CYC packets. The > > decoder also estimates timestamps based on the number of instructions since > > the last timestamp. For that to work in cycle-accurate mode, the > > instruction count needs to be reset to zero when a timestamp is calculated > > from a CYC packet, but that wasn't happening, so fix it. > > > > Signed-off-by: Adrian Hunter > > Cc: stable@vger.kernel.org # v4.3+ > > Hi > > These 2 patches are still outstanding when you have time. Thanks for the reminder, applied. > Regards > Adrian > > > --- > > tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > > index 7591a0c37473..3d1d446f037f 100644 > > --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > > +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c > > @@ -1353,6 +1353,8 @@ static void intel_pt_calc_cyc_timestamp(struct intel_pt_decoder *decoder) > > timestamp, decoder->timestamp); > > else > > decoder->timestamp = timestamp; > > + > > + decoder->timestamp_insn_cnt = 0; > > } > > > > /* Walk PSB+ packets when already in sync. */ > >