From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brnwk-0008Fa-8W for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:17:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brnwf-00085X-8D for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:17:26 -0400 Date: Wed, 5 Oct 2016 17:17:06 +0200 From: Kevin Wolf Message-ID: <20161005151706.GG1657@noname.str.redhat.com> References: <1475272849-19990-1-git-send-email-jsnow@redhat.com> <1475272849-19990-10-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475272849-19990-10-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 09/11] blockjob: add block_job_start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, vsementsov@virtuozzo.com, famz@redhat.com, stefanha@redhat.com, jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org Am 01.10.2016 um 00:00 hat John Snow geschrieben: > Instead of automatically starting jobs at creation time via backup_start > et al, we'd like to return a job object pointer that can be started > manually at later point in time. > > For now, add the block_job_start mechanism and start the jobs > automatically as we have been doing, with conversions job-by-job coming > in later patches. > > Of note: cancellation of unstarted jobs will perform all the normal > cleanup as if the job had started, particularly abort and clean. The > only difference is that we will not emit any events, because the job > never actually started. > > Signed-off-by: John Snow Should we make sure that jobs are only added to the block_jobs list once they are started? It doesn't sound like a good idea to make a job without a coroutine user-accessible. Kevin