From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932303AbcJEUlc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 16:41:32 -0400
Received: from mx2.suse.de ([195.135.220.15]:49929 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753161AbcJEUl3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 16:41:29 -0400
Date: Wed, 5 Oct 2016 22:41:26 +0200
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Daniel Wagner <wagi@monom.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "rafael.j.wysocki" <rafael.j.wysocki@intel.com>,
        Daniel Vetter <daniel.vetter@intel.com>, Takashi Iwai <tiwai@suse.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: Re: [PATCH v5 1/5] firmware: document user mode helper lock usage
Message-ID: <20161005204126.GG3296@wotan.suse.de>
References: <1473423144-21734-1-git-send-email-wagi@monom.org>
 <1473423144-21734-2-git-send-email-wagi@monom.org>
 <20160909221446.GO3296@wotan.suse.de>
 <CACVXFVMNAg7pPPx=b=pus8d-xDdbrhe=GqYtm_kyA8rnNmji8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACVXFVMNAg7pPPx=b=pus8d-xDdbrhe=GqYtm_kyA8rnNmji8A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2016 at 10:36:39AM +0800, Ming Lei wrote:
> On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> > On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote:
> >> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >>
> >> The lock is also used to generate warnings when a direct
> >> firmware load is requested too early.
> >
> > I've determined the firmware cache lets us bail out of this
> > consideration now. If Ming agrees with the logic we don't need this
> > patch and you can continue as you had intended. Sorry for the trouble.
> 
> IMO it is helpful to add comment about using the lock for direct loading,
> and we can sort it out in future if anyone want to improve it.
> 
> So for this patch, I am fine.

Yeah that's fine too. Thew new API, the driver data API will not use the UMH
lock, so we can just skip the lock there if we feel mushy about removing
it from the existing API on direct firmware loading. From what I've determined
though its simply not needed.

  Luis