From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755091AbcJEUqe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 16:46:34 -0400
Received: from mx2.suse.de ([195.135.220.15]:50313 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755033AbcJEUqc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 16:46:32 -0400
Date: Wed, 5 Oct 2016 22:46:28 +0200
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Ming Lei <ming.lei@canonical.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Daniel Wagner <wagi@monom.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "rafael.j.wysocki" <rafael.j.wysocki@intel.com>,
        Daniel Vetter <daniel.vetter@intel.com>, Takashi Iwai <tiwai@suse.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH v5 1/5] firmware: document user mode helper lock usage
Message-ID: <20161005204628.GH3296@wotan.suse.de>
References: <1473423144-21734-1-git-send-email-wagi@monom.org>
 <1473423144-21734-2-git-send-email-wagi@monom.org>
 <20160909221446.GO3296@wotan.suse.de>
 <CACVXFVMNAg7pPPx=b=pus8d-xDdbrhe=GqYtm_kyA8rnNmji8A@mail.gmail.com>
 <ab544ba0-2128-055f-3190-6a1a24e879e1@bmw-carit.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ab544ba0-2128-055f-3190-6a1a24e879e1@bmw-carit.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2016 at 10:13:44AM +0200, Daniel Wagner wrote:
> On 09/22/2016 04:36 AM, Ming Lei wrote:
> >On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> >>On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote:
> >>>From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >>>
> >>>The lock is also used to generate warnings when a direct
> >>>firmware load is requested too early.
> >>
> >>I've determined the firmware cache lets us bail out of this
> >>consideration now. If Ming agrees with the logic we don't need this
> >>patch and you can continue as you had intended. Sorry for the trouble.
> >
> >IMO it is helpful to add comment about using the lock for direct loading,
> >and we can sort it out in future if anyone want to improve it.
> >
> >So for this patch, I am fine.
> 
> Sorry, I am a bit confused now. What is the consensus here:
> 
>  a) add a comment to _request_firmware() as in this patch #1 v5

The adding a comment note from Daniel was that the UMH lock is *not*
needed on the direct firmware loading case, he's lazy to remove it
now so he'll just add a comment.

>  b) move the umh locking to fw_load_from_user_helper() as in
>     patch #1 v4

This is fine and IMHO the non-lazy approach.

To be clear -- I did my own vetting of the removal of the lock by
inspecting the original purpose of the UMH lock being added on the
history Linux git tree, having a secondary review of that would be
appreciated as well.

  Luis