From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Jitendra Khasdev <jkhasdev@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
gregkh@linuxfoundation.org, bankarsandhya512@gmail.com,
saurabh.truth@gmail.com, amitoj1606@gmail.com,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul
Date: Wed, 5 Oct 2016 23:11:09 +0200 [thread overview]
Message-ID: <20161005211109.GD7253@var> (raw)
In-Reply-To: <1475699578-31474-1-git-send-email-jkhasdev@gmail.com>
Hello,
Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.
> + unsigned long val;
> +
> + if (kstrtoul(start, 10, &val))
> + return NULL;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> if (*start == ',')
simple_strtoul modifies start, so you can't just replace it with
kstrtoul.
Samuel
prev parent reply other threads:[~2016-10-05 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 20:32 [PATCH] staging: speakup: Replaced obsolete simple_strtoul Jitendra Khasdev
2016-10-05 21:11 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005211109.GD7253@var \
--to=samuel.thibault@ens-lyon.org \
--cc=amitoj1606@gmail.com \
--cc=bankarsandhya512@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jkhasdev@gmail.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=saurabh.truth@gmail.com \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.