From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Michal Sojka <sojkam1@fel.cvut.cz>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Aaron Conole <aconole@bytheb.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: error: 'struct net_device' has no member named 'nf_hooks_ingress'
Date: Thu, 6 Oct 2016 13:31:39 +0900 [thread overview]
Message-ID: <20161006043139.GB5458@swordfish> (raw)
In-Reply-To: <1475701886.28155.223.camel@edumazet-glaptop3.roam.corp.google.com>
On (10/06/16 06:11), Eric Dumazet wrote:
> On Wed, 2016-10-05 at 22:56 +0200, Michal Sojka wrote:
>
> > this commit is now in mainline as
> > e3b37f11e6e4e6b6f02cc762f182ce233d2c1c9d and it breaks my build:
> >
> > net/netfilter/core.c: In function 'nf_set_hooks_head':
> > net/netfilter/core.c:96:3: error: 'struct net_device' has no member named 'nf_hooks_ingress'
> >
> > Are the fixes (see below) on the way to mainline too?
>
> Yes the fixes are already in nf tree and _will_ get pushed.
>
> Pablo and David are attending netdev 1.2 in Tokyo and have obligations.
>
> https://git.kernel.org/cgit/linux/kernel/git/pablo/nf-next.git/
well, I did my best to avoid it, but the guys didn't even bother to
reply. pushing a knowingly broken patch that
a) kills the build
b) introduces a race
c) requires two "Fixes:" followup patches
to the main line despite the fact that those problems were discovered
at linux-next stage is totally un-cool.
-ss
prev parent reply other threads:[~2016-10-06 4:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 6:40 linux-next: Tree for Sep 27 Stephen Rothwell
2016-09-27 10:03 ` Sergey Senozhatsky
2016-10-04 0:48 ` Sergey Senozhatsky
2016-10-05 20:56 ` error: 'struct net_device' has no member named 'nf_hooks_ingress' Michal Sojka
2016-10-05 20:56 ` Michal Sojka
2016-10-05 21:11 ` Eric Dumazet
2016-10-06 4:31 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006043139.GB5458@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=aconole@bytheb.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.